Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update @ngrx/store-devtools examples to standalone #4558

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

sheikalthaf
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

@ngrx/store-devtools documentation is using Modules and Standalone API is stable since v16.

Closes #4470

What is the new behavior?

Updated the @ngrx/store-devtools documentation to use standalone

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 61f8dcf
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6734fc6a2ff0300008bc5e42
😎 Deploy Preview https://deploy-preview-4558--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include a link to the v17 logs from the index file please?
Something like the other pages:

<div class="alert is-helpful">

An example of the `@ngrx/store-devtools` setup in module-based applications is available at the [following link](https://v17.ngrx.io/guide/store-devtools).

</div>

projects/ngrx.io/content/guide/store-devtools/config.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/guide/store-devtools/index.md Outdated Show resolved Hide resolved
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @sheikalthaf
I added a few small comments, which I committed manually.

projects/ngrx.io/content/guide/store-devtools/install.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/guide/store-devtools/config.md Outdated Show resolved Hide resolved
projects/ngrx.io/content/guide/store-devtools/index.md Outdated Show resolved Hide resolved
@brandonroberts brandonroberts merged commit de3ebce into ngrx:main Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/store-devtools: Update examples to standalone APIs
3 participants